Commit r4244: Reduce number of includes in default style

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Commit r4244: Reduce number of includes in default style

svn commit
Version mkgmap-r4244 was committed by gerd on Mon, 24 Sep 2018

Reduce number of includes in default style

The removed includes were only included in one file and some rules were repeated.
unIncDefault.patch by Ticker Berkin



http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4244
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4244: Reduce number of includes in default style

Carlos Dávila-2
El 24/9/18 a las 9:37, svn commit escribió:

> Version mkgmap-r4244 was committed by gerd on Mon, 24 Sep 2018
>
> Reduce number of includes in default style
>
> The removed includes were only included in one file and some rules were repeated.
> unIncDefault.patch by Ticker Berkin
>
>
>
>
I've noticed this commit removes the rules
landuse=military [0x640b resolution 24]
landuse=village_green & name=* [0x2c06 resolution 24]

from landuse_points,

but doesn't add the same lines to points file. Is it intended?

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4244: Reduce number of includes in default style

Gerd Petermann
Hi Carlos,

both rules exist in the points file, the include duplicated them.

Gerd

________________________________________
Von: mkgmap-dev <[hidden email]> im Auftrag von Carlos Dávila <[hidden email]>
Gesendet: Montag, 24. September 2018 23:11
An: [hidden email]
Betreff: Re: [mkgmap-dev] Commit r4244: Reduce number of includes in default style

El 24/9/18 a las 9:37, svn commit escribió:

> Version mkgmap-r4244 was committed by gerd on Mon, 24 Sep 2018
>
> Reduce number of includes in default style
>
> The removed includes were only included in one file and some rules were repeated.
> unIncDefault.patch by Ticker Berkin
>
>
>
>
I've noticed this commit removes the rules
landuse=military [0x640b resolution 24]
landuse=village_green & name=* [0x2c06 resolution 24]

from landuse_points,

but doesn't add the same lines to points file. Is it intended?

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4244: Reduce number of includes in default style

Carlos Dávila-2
Sorry, I was looking at my own style, which I thought was like default
in this part.

El 25/9/18 a las 7:54, Gerd Petermann escribió:

> Hi Carlos,
>
> both rules exist in the points file, the include duplicated them.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev <[hidden email]> im Auftrag von Carlos Dávila <[hidden email]>
> Gesendet: Montag, 24. September 2018 23:11
> An: [hidden email]
> Betreff: Re: [mkgmap-dev] Commit r4244: Reduce number of includes in default style
>
> El 24/9/18 a las 9:37, svn commit escribió:
>> Version mkgmap-r4244 was committed by gerd on Mon, 24 Sep 2018
>>
>> Reduce number of includes in default style
>>
>> The removed includes were only included in one file and some rules were repeated.
>> unIncDefault.patch by Ticker Berkin
>>
>>
>>
>>
> I've noticed this commit removes the rules
> landuse=military [0x640b resolution 24]
> landuse=village_green & name=* [0x2c06 resolution 24]
>
> from landuse_points,
>
> but doesn't add the same lines to points file. Is it intended?
>

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4244: Reduce number of includes in default style

Ticker Berkin
Hi Carlos

Also watch out for:

natural=coastline [0x15 resolution 12]

that is in lines and was also in inc/water_lines

Ticker


On Tue, 2018-09-25 at 08:36 +0200, Carlos Dávila wrote:

> Sorry, I was looking at my own style, which I thought was like
> default
> in this part.
>
> El 25/9/18 a las 7:54, Gerd Petermann escribió:
> > Hi Carlos,
> >
> > both rules exist in the points file, the include duplicated them.
> >
> > Gerd
> >
> > ________________________________________
> > Von: mkgmap-dev <[hidden email]> im Auftrag
> > von Carlos Dávila <[hidden email]>
> > Gesendet: Montag, 24. September 2018 23:11
> > An: [hidden email]
> > Betreff: Re: [mkgmap-dev] Commit r4244: Reduce number of includes
> > in default style
> >
> > El 24/9/18 a las 9:37, svn commit escribió:
> > > Version mkgmap-r4244 was committed by gerd on Mon, 24 Sep 2018
> > >
> > > Reduce number of includes in default style
> > >
> > > The removed includes were only included in one file and some
> > > rules were repeated.
> > > unIncDefault.patch by Ticker Berkin
> > >
> > >
> > >
> > >
> > I've noticed this commit removes the rules
> > landuse=military [0x640b resolution 24]
> > landuse=village_green & name=* [0x2c06 resolution 24]
> >
> > from landuse_points,
> >
> > but doesn't add the same lines to points file. Is it intended?
> >
>
> _______________________________________________
> mkgmap-dev mailing list
> [hidden email]
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev