Commit r4251: Check size of TYP polygon bitmap

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Commit r4251: Check size of TYP polygon bitmap

svn commit
Version mkgmap-r4251 was committed by steve on Mon, 12 Nov 2018

Check size of TYP polygon bitmap

They can only be 32x32 so fail if a different size.


http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4251
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4251: Check size of TYP polygon bitmap

nwillink
@Steve

The same needs to be done for 'width' of  lines with bitmaps.

At the moment it accepts 16  and perhaps values other than 32.

Best regards

Nick


On 12/11/2018 21:47, svn commit wrote:

> Version mkgmap-r4251 was committed by steve on Mon, 12 Nov 2018
>
> Check size of TYP polygon bitmap
>
> They can only be 32x32 so fail if a different size.
>
>
> http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4251
> _______________________________________________
> mkgmap-dev mailing list
> [hidden email]
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4251: Check size of TYP polygon bitmap

steve sgalowski
Nick I will re.do the latest commit check with nuvi 1450 ? 

Stephen 

On Tue, 13 Nov. 2018, 8:40 am osm@pinns <[hidden email] wrote:
@Steve

The same needs to be done for 'width' of  lines with bitmaps.

At the moment it accepts 16  and perhaps values other than 32.

Best regards

Nick


On 12/11/2018 21:47, svn commit wrote:
> Version mkgmap-r4251 was committed by steve on Mon, 12 Nov 2018
>
> Check size of TYP polygon bitmap
>
> They can only be 32x32 so fail if a different size.
>
>
> http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4251
> _______________________________________________
> mkgmap-dev mailing list
> [hidden email]
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4251: Check size of TYP polygon bitmap

nwillink

I forgot to check this with r4251 which indeed reports wrong linewidth!



On 12/11/2018 22:51, Steve Sgalowski wrote:
Nick I will re.do the latest commit check with nuvi 1450 ? 

Stephen 

On Tue, 13 Nov. 2018, 8:40 am osm@pinns <[hidden email] wrote:
@Steve

The same needs to be done for 'width' of  lines with bitmaps.

At the moment it accepts 16  and perhaps values other than 32.

Best regards

Nick


On 12/11/2018 21:47, svn commit wrote:
> Version mkgmap-r4251 was committed by steve on Mon, 12 Nov 2018
>
> Check size of TYP polygon bitmap
>
> They can only be 32x32 so fail if a different size.
>
>
> http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4251
> _______________________________________________
> mkgmap-dev mailing list
> [hidden email]
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4251: Check size of TYP polygon bitmap

Steve Ratcliffe
On 13/11/2018 10:46, osm@pinns wrote:
> I forgot to check this with r4251 which indeed reports wrong linewidth!

Are you sure?  I don't think it does!

You are right and it needs a check as the width is not saved
anywhere so it must be 32.  Here is a patch to add the check.

Steve


_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Line_pixmap_width_check.patch (959 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4251: Check size of TYP polygon bitmap

nwillink

Thanks Steve

Another issue is that at the moment TYP compiler does not support codepage 65001.

Nick


On 13/11/2018 13:53, Steve Ratcliffe wrote:
On 13/11/2018 10:46, osm@pinns wrote:
I forgot to check this with r4251 which indeed reports wrong linewidth!

Are you sure?  I don't think it does!

You are right and it needs a check as the width is not saved
anywhere so it must be 32.  Here is a patch to add the check.

Steve


_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4251: Check size of TYP polygon bitmap

Steve Ratcliffe

Hi Nick

> Another issue is that at the moment TYP compiler does not support
> codepage 65001.

OK thanks, please try the attached patch.

Steve

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

cp65001_and_width_check1.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Commit r4251: Check size of TYP polygon bitmap

nwillink

Hi Steve

Thanks , unfortunately I'm no good with patches so will wait when it's committed

Nick

On 13/11/2018 19:02, Steve Ratcliffe wrote:

Hi Nick

Another issue is that at the moment TYP compiler does not support codepage 65001.

OK thanks, please try the attached patch.

Steve

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev