[Patch v4] style statistics

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch v4] style statistics

Gerd Petermann
Hi all,

attached is v4. It adds some documentation, no functional change to v3.

I'll commit this the next days if nobody finds a better solution.

Gerd

_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

styleStats-v4.patch (18K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch v4] style statistics

Axel Herold
Gerd Petermann schrieb (23/11/14 -- 10:21):

> attached is v4. It adds some documentation, no functional change to v3.

Hi Gerd,

after playing around with this a bit more I wonder why the parameter
(--report-style-stats) is actually needed. Wouldn't it suffice to
configure the logging properties? Currently you have to provide the
parameter *and* have your logging properties configured to eventually
set uk.me.parabola.mkgmap.osmstyle.StyleImpl.level=INFO (or FINE).

The style stats are basically debug information and they should be
configured in one place only (the log.props).

Viele Grüße,
Axel.
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Patch v4] style statistics

Gerd Petermann
Hi Alex,

I think you are right, thanks for pointing this out. I'll post v5 of the patch.

Gerd

Axel Herold wrote
Gerd Petermann schrieb (23/11/14 -- 10:21):

> attached is v4. It adds some documentation, no functional change to v3.

Hi Gerd,

after playing around with this a bit more I wonder why the parameter
(--report-style-stats) is actually needed. Wouldn't it suffice to
configure the logging properties? Currently you have to provide the
parameter *and* have your logging properties configured to eventually
set uk.me.parabola.mkgmap.osmstyle.StyleImpl.level=INFO (or FINE).

The style stats are basically debug information and they should be
configured in one place only (the log.props).

Viele Grüße,
Axel.
_______________________________________________
mkgmap-dev mailing list
[hidden email]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev