small updates ...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

small updates ...

Jody Garnett-2
It seems I am too busy to send large updates; so here are a series of small updates on feature panel implementing; mostly for moovida who would like to make his own shortly.

Code review with Jesse
- thanks to jesse for code review
- we *could* get away with using PropertyEditor heirarchy (probably) but it forces the use of grid layouer; and we would like to use mig layout. And we are editing attributes and attribute desriptor performs a lot of the validation for us already
-

Things for implementors:
- FeaturePanel is an abstract implementation of IFeaturePanel; it offers an implementation of refresh/dispose/etc build around a list of attributefields; you populate that list with an addField method
- keep looking at country feature panel as an example

Jody
_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel
Reply | Threaded
Open this post in threaded view
|

Re: small updates ...

Jody Garnett-2
Second small update:
- The Feature View is now done
- I added a title bar that shows the FeatureID right now; I could see registering a LabelProvider per FeatureType (ie being able to make nice titles for a feature would be good!)

Moving on to poping up a dialog:
- found the correct place for a hook (and am just popping up a message dialog now if there are any panels available
- will make a dialog out of the panels tomorrow
- will revise IFeatureSite based on the experience

Any questions Andrea? Are you going to manage to look at things?

Jody

On 04/05/2010, at 2:09 PM, Jody Garnett wrote:

> It seems I am too busy to send large updates; so here are a series of small updates on feature panel implementing; mostly for moovida who would like to make his own shortly.
>
> Code review with Jesse
> - thanks to jesse for code review
> - we *could* get away with using PropertyEditor heirarchy (probably) but it forces the use of grid layouer; and we would like to use mig layout. And we are editing attributes and attribute desriptor performs a lot of the validation for us already
> -
>
> Things for implementors:
> - FeaturePanel is an abstract implementation of IFeaturePanel; it offers an implementation of refresh/dispose/etc build around a list of attributefields; you populate that list with an addField method
> - keep looking at country feature panel as an example
>
> Jody

_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel
Reply | Threaded
Open this post in threaded view
|

Re: small updates ...

Andrea Antonello
Hi Jody,
thanks for the updates. I am back in the office now.
I will look into all those things this afternoon/evening.

One quick and small question right away: I see the feature editing
occurs through the DIRTY in the getData object. Then probably the
value of the component is taken and put into the feature to modify it.
Doe the superclass traverse all the components searching for that
attribute?
Is it possible for me to tweak that? For example I might have a combo
with names of cities, but in fact in the feature attribute a code for
them should be written.
Example: I see:
merano, bolzano, trento

and when I select merano, a 1 should be written in the attribute
table, in the case of Bolzano a 2 and so on.

I will get back to you when I went through the code, thanks for the updates,
Andrea


On Tue, May 4, 2010 at 4:24 PM, Jody Garnett <[hidden email]> wrote:

> Second small update:
> - The Feature View is now done
> - I added a title bar that shows the FeatureID right now; I could see registering a LabelProvider per FeatureType (ie being able to make nice titles for a feature would be good!)
>
> Moving on to poping up a dialog:
> - found the correct place for a hook (and am just popping up a message dialog now if there are any panels available
> - will make a dialog out of the panels tomorrow
> - will revise IFeatureSite based on the experience
>
> Any questions Andrea? Are you going to manage to look at things?
>
> Jody
>
> On 04/05/2010, at 2:09 PM, Jody Garnett wrote:
>
>> It seems I am too busy to send large updates; so here are a series of small updates on feature panel implementing; mostly for moovida who would like to make his own shortly.
>>
>> Code review with Jesse
>> - thanks to jesse for code review
>> - we *could* get away with using PropertyEditor heirarchy (probably) but it forces the use of grid layouer; and we would like to use mig layout. And we are editing attributes and attribute desriptor performs a lot of the validation for us already
>> -
>>
>> Things for implementors:
>> - FeaturePanel is an abstract implementation of IFeaturePanel; it offers an implementation of refresh/dispose/etc build around a list of attributefields; you populate that list with an addField method
>> - keep looking at country feature panel as an example
>>
>> Jody
>
>
_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel
Reply | Threaded
Open this post in threaded view
|

Re: small updates ...

Jody Garnett-2
More small updates (and comment inline).
- working on enable/disable/visibility
- thinking I will let attribute fields always hit the EditFeature; and that would free up listeners *just* for change value and change validation events

Jody

On 05/05/2010, at 4:56 PM, andrea antonello wrote:
> One quick and small question right away: I see the feature editing
> occurs through the DIRTY in the getData object. Then probably the
> value of the component is taken and put into the feature to modify it.
> Doe the superclass traverse all the components searching for that
> attribute?

Actually the isDirty map is not being used; I put it there in case it would help Myles.
Right now each attribute field is calling feature.setAttribute( name, value ) as needed
you can configure them to send on every keypress; or to send  when they lose focus.

> Is it possible for me to tweak that? For example I might have a combo
> with names of cities, but in fact in the feature attribute a code for
> them should be written.

For combo's use the ComboAttributeField; and supply your own
label renderer to the internal ComboViewer (so that your labels
do not have to be codes).

> Example: I see:
> merano, bolzano, trento
>
> and when I select merano, a 1 should be written in the attribute
> table, in the case of Bolzano a 2 and so on.

Just so; I will update the country feature panel tutorial code to illustrate this case.

> I will get back to you when I went through the code, thanks for the updates,

Yeah jump online and we can do a shared screen review of the country feature panel; it will save you time and I will enjoy the feedback.
Jody

> Andrea
>
>
> On Tue, May 4, 2010 at 4:24 PM, Jody Garnett <[hidden email]> wrote:
>> Second small update:
>> - The Feature View is now done
>> - I added a title bar that shows the FeatureID right now; I could see registering a LabelProvider per FeatureType (ie being able to make nice titles for a feature would be good!)
>>
>> Moving on to poping up a dialog:
>> - found the correct place for a hook (and am just popping up a message dialog now if there are any panels available
>> - will make a dialog out of the panels tomorrow
>> - will revise IFeatureSite based on the experience
>>
>> Any questions Andrea? Are you going to manage to look at things?
>>
>> Jody
>>
>> On 04/05/2010, at 2:09 PM, Jody Garnett wrote:
>>
>>> It seems I am too busy to send large updates; so here are a series of small updates on feature panel implementing; mostly for moovida who would like to make his own shortly.
>>>
>>> Code review with Jesse
>>> - thanks to jesse for code review
>>> - we *could* get away with using PropertyEditor heirarchy (probably) but it forces the use of grid layouer; and we would like to use mig layout. And we are editing attributes and attribute desriptor performs a lot of the validation for us already
>>> -
>>>
>>> Things for implementors:
>>> - FeaturePanel is an abstract implementation of IFeaturePanel; it offers an implementation of refresh/dispose/etc build around a list of attributefields; you populate that list with an addField method
>>> - keep looking at country feature panel as an example
>>>
>>> Jody
>>
>>
> _______________________________________________
> User-friendly Desktop Internet GIS (uDig)
> http://udig.refractions.net
> http://lists.refractions.net/mailman/listinfo/udig-devel

_______________________________________________
User-friendly Desktop Internet GIS (uDig)
http://udig.refractions.net
http://lists.refractions.net/mailman/listinfo/udig-devel